NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

apps: cam: capture_script: Disallow arrays of strings

Browse source 
The current `ControlValue` mechanism does not support arrays
of strings, the assignment in the removed snippet will in fact
trigger an assertion failure in `ControlValue::set()` because
`sizeof(std::string) != ControlValueSize[ControlTypeString]`.

Fixes: b35f04b3c1 ("cam: capture_script: Support parsing array controls")
Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
This commit is contained in:
Barnabás Pőcze 2025-04-22 12:27:06 +02:00
parent ffcecda4d5
commit 702af1a1d0
1 changed files with 0 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/apps/cam/capture_script.cpp
View file

@ -578,10 +578,6 @@ ControlValue CaptureScript::parseArrayControl(const ControlId *id,
value = Span<const float>(values.data(), values.size()); value = Span<const float>(values.data(), values.size());
break; break;
} }
case ControlTypeString: {
value = Span<const std::string>(repr.data(), repr.size());
break;
}
default: default:
std::cerr << "Unsupported control type" << std::endl; std::cerr << "Unsupported control type" << std::endl;
break; break;