NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

libcamera: software_isp: Use a specific integer type for black level

Browse source 
The documented range of values corresponds to uint8_t, so let's use that
type.

Signed-off-by: Milan Zamazal <mzamazal@redhat.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Andrei Konovalov <andrey.konovalov.ynk@gmail.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
This commit is contained in:
Milan Zamazal 2024-05-31 14:38:36 +02:00 • committed by Laurent Pinchart
parent aad5837d70
commit 738bd37905
2 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/ipa/simple/black_level.cpp
View file

@ -43,7 +43,7 @@ BlackLevel::BlackLevel()
* \return The black level, in the range from 0 (minimum) to 255 (maximum). * \return The black level, in the range from 0 (minimum) to 255 (maximum).
* If the black level couldn't be determined yet, return 0. * If the black level couldn't be determined yet, return 0.
*/ */
unsigned int BlackLevel::get() const uint8_t BlackLevel::get() const
{ {
return blackLevelSet_ ? blackLevel_ : 0; return blackLevelSet_ ? blackLevel_ : 0;
} }

5
src/ipa/simple/black_level.h
View file

@ -8,6 +8,7 @@
#pragma once #pragma once
#include <array> #include <array>
#include <stdint.h>
#include "libcamera/internal/software_isp/swisp_stats.h" #include "libcamera/internal/software_isp/swisp_stats.h"
@ -17,11 +18,11 @@ class BlackLevel
{ {
public: public:
BlackLevel(); BlackLevel();
unsigned int get() const; uint8_t get() const;
void update(SwIspStats::Histogram &yHistogram); void update(SwIspStats::Histogram &yHistogram);
private: private:
unsigned int blackLevel_; uint8_t blackLevel_;
bool blackLevelSet_; bool blackLevelSet_;
}; };