NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

libcamera: pipeline: uvcvideo: Treat all UVC cameras as external

Browse source 
We currently have no way to identify if the UVC device is external
or internal(i.e. non-removable) to the system to set this property.
Until we have a starting point to resolve this, treat  all UVC cameras.
Add a \todo explaining the situation for the same.

Signed-off-by: Umang Jain <email@uajain.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
This commit is contained in:
Umang Jain 2020-08-21 14:46:06 +00:00 • committed by Laurent Pinchart
parent 33fe27741b
commit 76809320bb
1 changed files with 7 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/libcamera/pipeline/uvcvideo/uvcvideo.cpp
View file

@ -14,6 +14,7 @@
#include <libcamera/camera.h> #include <libcamera/camera.h>
#include <libcamera/control_ids.h> #include <libcamera/control_ids.h>
#include <libcamera/controls.h> #include <libcamera/controls.h>
#include <libcamera/property_ids.h>
#include <libcamera/request.h> #include <libcamera/request.h>
#include <libcamera/stream.h> #include <libcamera/stream.h>
@ -500,6 +501,12 @@ int UVCCameraData::init(MediaEntity *entity)
video_->bufferReady.connect(this, &UVCCameraData::bufferReady); video_->bufferReady.connect(this, &UVCCameraData::bufferReady);
/*
* \todo Find a way to tell internal and external UVC cameras apart.
* Until then, treat all UVC cameras as external.
*/
properties_.set(properties::Location, properties::CameraLocationExternal);
/* Initialise the supported controls. */ /* Initialise the supported controls. */
ControlInfoMap::Map ctrls; ControlInfoMap::Map ctrls;