NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

ipa: rkisp1: Raise maximum analogue gain

Browse source 
Omnivision OV4689 sensor driver exposes maximum analogue gain of
16x. Raise kMaxAnalogueGain to 16.0, so that the full gain range can
be used.

Signed-off-by: Mikhail Rudenko <mike.rudenko@gmail.com>
Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
This commit is contained in:
Mikhail Rudenko 2023-01-23 17:06:19 +03:00 • committed by Jacopo Mondi
parent d500930e7d
commit 7986d3d3c1
1 changed files with 7 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/ipa/rkisp1/algorithms/agc.cpp
View file

@ -36,9 +36,14 @@ namespace ipa::rkisp1::algorithms {
LOG_DEFINE_CATEGORY(RkISP1Agc) LOG_DEFINE_CATEGORY(RkISP1Agc)
/* Limits for analogue gain values */ /*
* Limits for analogue gain values
*
* \todo Remove the hard-coded limits and let the sensor helper specify
* the minimum and maximum allowed gain values.
*/
static constexpr double kMinAnalogueGain = 1.0; static constexpr double kMinAnalogueGain = 1.0;
static constexpr double kMaxAnalogueGain = 8.0; static constexpr double kMaxAnalogueGain = 16.0;
/* \todo Honour the FrameDurationLimits control instead of hardcoding a limit */ /* \todo Honour the FrameDurationLimits control instead of hardcoding a limit */
static constexpr utils::Duration kMaxShutterSpeed = 60ms; static constexpr utils::Duration kMaxShutterSpeed = 60ms;