NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

android: post_processor_jpeg: Make |cameraDevice_| constant

Browse source 
PostProcessorJpeg doesn't have the ownership of CameraDevice given
in the constructor. To clarify it, this makes the member variable
constant.

Signed-off-by: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Umang Jain <email@uajain.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
This commit is contained in:
Hirokazu Honda 2020-10-21 10:39:54 +09:00 • committed by Kieran Bingham
parent 90c193f2a7
commit 79bca4300b
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/android/jpeg/post_processor_jpeg.cpp
View file

@ -20,7 +20,7 @@ using namespace libcamera;
LOG_DEFINE_CATEGORY(JPEG) LOG_DEFINE_CATEGORY(JPEG)
PostProcessorJpeg::PostProcessorJpeg(CameraDevice *device) PostProcessorJpeg::PostProcessorJpeg(CameraDevice *const device)
: cameraDevice_(device) : cameraDevice_(device)
{ {
} }

4
src/android/jpeg/post_processor_jpeg.h
View file

@ -19,7 +19,7 @@ class CameraDevice;
class PostProcessorJpeg : public PostProcessor class PostProcessorJpeg : public PostProcessor
{ {
public: public:
PostProcessorJpeg(CameraDevice *device); PostProcessorJpeg(CameraDevice *const device);
int configure(const libcamera::StreamConfiguration &incfg, int configure(const libcamera::StreamConfiguration &incfg,
const libcamera::StreamConfiguration &outcfg) override; const libcamera::StreamConfiguration &outcfg) override;
@ -28,7 +28,7 @@ public:
CameraMetadata *metadata) override; CameraMetadata *metadata) override;
private: private:
CameraDevice *cameraDevice_; CameraDevice *const cameraDevice_;
std::unique_ptr<Encoder> encoder_; std::unique_ptr<Encoder> encoder_;
libcamera::Size streamSize_; libcamera::Size streamSize_;
}; };