NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

utils: checkstyle: Ensure "..." include style for internal headers

Browse source 
libcamera uses the "..." include style for internal headers. Enforce it.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
This commit is contained in:
Laurent Pinchart 2022-05-26 13:18:23 +03:00
parent c58ac2f498
commit 7a529a9e35
1 changed files with 16 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

18
utils/checkstyle.py
View file

@ -643,7 +643,7 @@ class DPointerFormatter(Formatter):
class IncludeOrderFormatter(Formatter):
patterns = ('*.cpp', '*.h')
include_regex = re.compile('^#include ["<]([^">]*)[">]')
include_regex = re.compile('^#include (["<])([^">]*)([">])')
@classmethod
def format(cls, filename, data):
@ -657,7 +657,21 @@ class IncludeOrderFormatter(Formatter):
if match:
# If the current line is an #include statement, add it to the
# includes group and continue to the next line.
includes.append((line, match.group(1)))
open_token = match.group(1)
file_name = match.group(2)
close_token = match.group(3)
# Ensure the "..." include style for internal headers and the
# <...> style for all other libcamera headers.
if (file_name.startswith('libcamera/internal')):
open_token = '"'
close_token = '"'
elif (file_name.startswith('libcamera/')):
open_token = '<'
close_token = '>'
line = f'#include {open_token}{file_name}{close_token}'
includes.append((line, file_name))
continue
# The current line is not an #include statement, output the sorted