NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

libcamera: v4l2_device: Fix error messages in setControls()

Browse source 
The error messages are copied from getControls() without being updated
for the set controls case, fix this.

Fixes: eb068f4e67 ("libcamera: v4l2_device: Implement get and set controls")
Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
Acked-by: Jacopo Mondi <jacopo@jmondi.org>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
This commit is contained in:
Niklas Söderlund 2019-08-29 10:05:22 +02:00
parent 8a92e6fc72
commit 808a7fc04e
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/libcamera/v4l2_device.cpp
View file

@ -287,13 +287,13 @@ int V4L2Device::setControls(V4L2ControlList *ctrls)
/* Generic validation error. */ /* Generic validation error. */
if (errorIdx == 0 || errorIdx >= count) { if (errorIdx == 0 || errorIdx >= count) {
LOG(V4L2, Error) << "Unable to read controls: " LOG(V4L2, Error) << "Unable to set controls: "
<< strerror(ret); << strerror(ret);
return -EINVAL; return -EINVAL;
} }
/* A specific control failed. */ /* A specific control failed. */
LOG(V4L2, Error) << "Unable to read control " << errorIdx LOG(V4L2, Error) << "Unable to set control " << errorIdx
<< ": " << strerror(ret); << ": " << strerror(ret);
count = errorIdx - 1; count = errorIdx - 1;
ret = errorIdx; ret = errorIdx;