NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

libcamera: v4l2_videodevice: Warn if bytesused == 0 when queuing output buffer

Browse source 
V4L2 has deprecated queuing output buffers with bytesused set to 0. Warn
if the caller attempts to do so.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
Tested-by: Naushir Patuck <naush@raspberrypi.com>
This commit is contained in:
Laurent Pinchart 2022-10-05 01:21:28 +03:00
parent 87f507bbf2
commit 8108ba3202
1 changed files with 5 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/libcamera/v4l2_videodevice.cpp
View file

@ -1623,6 +1623,11 @@ int V4L2VideoDevice::queueBuffer(FrameBuffer *buffer)
if (V4L2_TYPE_IS_OUTPUT(buf.type)) { if (V4L2_TYPE_IS_OUTPUT(buf.type)) {
const FrameMetadata &metadata = buffer->metadata(); const FrameMetadata &metadata = buffer->metadata();
for (const auto &plane : metadata.planes()) {
if (!plane.bytesused)
LOG(V4L2, Warning) << "byteused == 0 is deprecated";
}
if (numV4l2Planes != planes.size()) { if (numV4l2Planes != planes.size()) {
/* /*
* If we have a multi-planar buffer with a V4L2 * If we have a multi-planar buffer with a V4L2