NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

libcamera: software_isp: Move a non-loop condition out of the loop

Browse source 
The check for the number of outputs is done in a loop over the outputs.
It should be moved out of the loop as it's not loop specific and is just
repeated there.

This is a cosmetic change not changing any functionality.

Signed-off-by: Milan Zamazal <mzamazal@redhat.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
This commit is contained in:
Milan Zamazal 2025-01-24 22:57:52 +01:00 • committed by Laurent Pinchart
parent f5da05ed03
commit 818b737146
1 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/libcamera/software_isp/software_isp.cpp
View file

@ -291,11 +291,13 @@ int SoftwareIsp::queueBuffers(uint32_t frame, FrameBuffer *input,
if (outputs.empty()) if (outputs.empty())
return -EINVAL; return -EINVAL;
/* We only support a single stream for now. */
if (outputs.size() != 1)
return -EINVAL;
for (auto [stream, buffer] : outputs) { for (auto [stream, buffer] : outputs) {
if (!buffer) if (!buffer)
return -EINVAL; return -EINVAL;
if (outputs.size() != 1) /* only single stream atm */
return -EINVAL;
} }
for (auto iter = outputs.begin(); iter != outputs.end(); iter++) for (auto iter = outputs.begin(); iter != outputs.end(); iter++)