NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

libcamera: rpi: pipeline_base: Remove populateSensorFormats()

Browse source 
populateSensorFormats() is a static helper that is called from a single
place and performs a simple loop over the sensor camera formats.

Remove it and in-line it in the caller to remove one static helper from
the pipeline_base.cpp file.

Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Reviewed-by: Naushir Patuck <naush@raspberrypi.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
This commit is contained in:
Jacopo Mondi 2023-07-12 11:55:08 +01:00
parent baaad1bf9e
commit 81fa10d87f
1 changed files with 4 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

15
src/libcamera/pipeline/rpi/common/pipeline_base.cpp
View file

@ -66,16 +66,6 @@ PixelFormat mbusCodeToPixelFormat(unsigned int mbus_code,
return pix; return pix;
} }
SensorFormats populateSensorFormats(std::unique_ptr<CameraSensor> &sensor)
{
SensorFormats formats;
for (auto const mbusCode : sensor->mbusCodes())
formats.emplace(mbusCode, sensor->sizes(mbusCode));
return formats;
}
bool isMonoSensor(std::unique_ptr<CameraSensor> &sensor) bool isMonoSensor(std::unique_ptr<CameraSensor> &sensor)
{ {
unsigned int mbusCode = sensor->mbusCodes()[0]; unsigned int mbusCode = sensor->mbusCodes()[0];
@ -804,7 +794,10 @@ int PipelineHandlerBase::registerCamera(std::unique_ptr<RPi::CameraData> &camera
if (data->sensor_->init()) if (data->sensor_->init())
return -EINVAL; return -EINVAL;
data->sensorFormats_ = populateSensorFormats(data->sensor_); /* Populate the map of sensor supported formats and sizes. */
for (auto const mbusCode : data->sensor_->mbusCodes())
data->sensorFormats_.emplace(mbusCode,
data->sensor_->sizes(mbusCode));
/* /*
* Enumerate all the Video Mux/Bridge devices across the sensor -> Fr * Enumerate all the Video Mux/Bridge devices across the sensor -> Fr