NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

libcamera: Remove transform from V4L2SubdeviceFormat

Browse source 
Commit 6f6e1bf704 ("libcamera: camera_sensor: Apply flips at
setFormat()") extended the CameraSensor::setFormat() function
to apply vertical/horizontal flips on the sensor based on the
supplied Transform. To pass the Transform to the function the
V4L2SubdeviceFormat structure has been augmented with a Transform
member.

However as the newly added Transform is not used at all in the
V4L2Subdevice class, it should not be part of V4L2SubdeviceFormat.

Fix that by removing the transform field from V4L2SubdeviceFormat
and pass it as an explicit parameter to CameraSensor::setFormat().

Fixes: 6f6e1bf704 ("libcamera: camera_sensor: Apply flips at setFormat())
Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
This commit is contained in:
Jacopo Mondi 2023-02-06 19:21:32 +01:00
parent 3aa42f36c0
commit 85befa816e
7 changed files with 19 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

6
include/libcamera/internal/camera_sensor.h
View file

@ -17,6 +17,7 @@
#include <libcamera/control_ids.h>
#include <libcamera/controls.h>
#include <libcamera/geometry.h>
#include <libcamera/transform.h>
#include <libcamera/ipa/core_ipa_interface.h>
@ -29,8 +30,6 @@ class BayerFormat;
class CameraLens;
class MediaEntity;
enum class Transform;
struct CameraSensorProperties;
class CameraSensor : protected Loggable
@ -55,7 +54,8 @@ public:
V4L2SubdeviceFormat getFormat(const std::vector<unsigned int> &mbusCodes,
const Size &size) const;
int setFormat(V4L2SubdeviceFormat *format);
int setFormat(V4L2SubdeviceFormat *format,
Transform transform = Transform::Identity);
const ControlInfoMap &controls() const;
ControlList getControls(const std::vector<uint32_t> &ids);

2
include/libcamera/internal/v4l2_subdevice.h
View file

@ -20,7 +20,6 @@
#include <libcamera/color_space.h>
#include <libcamera/geometry.h>
#include <libcamera/transform.h>
#include "libcamera/internal/formats.h"
#include "libcamera/internal/media_object.h"
@ -45,7 +44,6 @@ struct V4L2SubdeviceFormat {
uint32_t mbus_code;
Size size;
std::optional<ColorSpace> colorSpace;
Transform transform = Transform::Identity;
const std::string toString() const;
uint8_t bitsPerPixel() const;