NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

libcamera: pipeline_handler: Update request usage comment

Browse source 
When a pipeline handler completes a request, the request itself is not
deleted by libcamera, and the application regains control over the
object. It may choose to delete the Request, or re-use it.

Clarify this in the comment by removing the declaration that the Request
is deleted, but state that it is no longer managed by the pipeline
handler and must not be accessed further after this function returns.

Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Umang Jain <email@uajain.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
This commit is contained in:
Kieran Bingham 2021-03-02 12:23:41 +00:00
parent 2cf0c87511
commit 8c81ab298e
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/libcamera/pipeline_handler.cpp
View file

@ -432,8 +432,8 @@ bool PipelineHandler::completeBuffer(Request *request, FrameBuffer *buffer)
* \param[in] request The request that has completed
*
* The pipeline handler shall call this method to notify the \a camera that the
* request has completed. The request is deleted and shall not be accessed once
* this method returns.
* request has completed. The request is no longer managed by the pipeline
* handler and shall not be accessed once this method returns.
*
* This method ensures that requests will be returned to the application in
* submission order, the pipeline handler may call it on any complete request