NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

libtuning: Only warn if processing returns None

Browse source 
There are valid cases where a module returns None. E.g. no images were
provided for LSC calibration. We should however define proper semantics
there. Continue with a warning for now.

Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
This commit is contained in:
Stefan Klug 2024-06-11 14:56:45 +02:00
parent 54a8405726
commit 8e411bfaef
2 changed files with 5 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
utils/tuning/libtuning/generators/yaml_output.py
View file

@ -107,6 +107,9 @@ class YamlOutput(Generator):
] ]
for module in output_order: for module in output_order:
if module not in output_dict:
continue
out_lines.append(f' - {module.out_name}:') out_lines.append(f' - {module.out_name}:')
if len(output_dict[module]) == 0: if len(output_dict[module]) == 0:

4
utils/tuning/libtuning/libtuning.py
View file

@ -200,8 +200,8 @@ class Tuner(object):
for module in self.modules: for module in self.modules:
out = module.process(self.config, images, self.output) out = module.process(self.config, images, self.output)
if out is None: if out is None:
logger.error(f'Module {module.hr_name} failed to process...') logger.warning(f'Module {module.hr_name} failed to process...')
break continue
self.output[module] = out self.output[module] = out
self.generator.write(args.output, self.output, self.output_order) self.generator.write(args.output, self.output, self.output_order)