NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

libcamera: rkisp1: Rectify SensorConfiguration check

Browse source 
The 'found' flag was mistakenly understood that a compatible sensor
format has been found when a sensor configuration is passed in. However,
'found' related to the stream configuration's pixelformat, whether it is
supported by the RkISP1Path video node or not. It does not relate to the
sensor format, hence the check:

	if (sensorConfig && !found)

doesn't make sense.

Rectify the above check with:

	if (sensorConfig && !rawFormat.isValid())

to ensure a sensor format compatible with sensor configuration has been
set to rawFormat.

Fixes: 047d647452 ("libcamera: rkisp1: Integrate SensorConfiguration support")
Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
This commit is contained in:
Umang Jain 2024-10-11 14:52:21 +05:30
parent 326e0aa834
commit a2be725d26
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/libcamera/pipeline/rkisp1/rkisp1_path.cpp
View file

@ -304,7 +304,7 @@ RkISP1Path::validate(const CameraSensor *sensor,
} }
} }
if (sensorConfig && !found) if (sensorConfig && !rawFormat.isValid())
return CameraConfiguration::Invalid; return CameraConfiguration::Invalid;
bool isRaw = PixelFormatInfo::info(cfg->pixelFormat).colourEncoding == bool isRaw = PixelFormatInfo::info(cfg->pixelFormat).colourEncoding ==