NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

test: fence: Check write return value

Browse source 
The ::write() function used to signal a framebuffer fence in the unit
test is marked with the 'warn_unused_result'.

When building in debugoptimized mode not checking for the return
value causes issues at build time:
/test/fence.cpp:254:2: error: ignoring return value of function declared with 'warn_unused_result' attribute

Fix that by checking the ::write() return value and emitting an
error message in case the write fails.

Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
Reported-by: Umang Jain <umang.jain@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Tested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
This commit is contained in:
Jacopo Mondi 2021-12-13 15:44:22 +01:00
parent 13fdf9d0dc
commit a3122eecea
1 changed files with 6 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

7
test/fence.cpp
View file

@ -251,7 +251,12 @@ void FenceTest::requestComplete(Request *request)
void FenceTest::signalFence()
{
uint64_t value = 1;
write(efd2_, &value, sizeof(value));
int ret;
ret = write(efd2_, &value, sizeof(value));
if (ret != sizeof(value))
cerr << "Failed to signal fence" << endl;
dispatcher_->processEvents();
}