NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

libcamera: software_isp: Remove file seal TODO item

Browse source 
The file seal TODO item has been addressed. Remove it.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Milan Zamazal <mzamazal@redhat.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Tested-by: Milan Zamazal <mzamazal@redhat.com>
Tested-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
This commit is contained in:
Laurent Pinchart 2024-07-31 02:23:12 +03:00
parent efc7a85bc0
commit a3ddf56a00
1 changed files with 0 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

19
src/libcamera/software_isp/TODO
View file

@ -1,22 +1,3 @@
1. Setting F_SEAL_SHRINK and F_SEAL_GROW after ftruncate()
>> SharedMem::SharedMem(const std::string &name, std::size_t size)
>> : name_(name), size_(size), mem_(nullptr)
>>
>> ...
>>
>> if (ftruncate(fd_.get(), size_) < 0)
>> return;
>
> Should we set the GROW and SHRINK seals (in a separate patch) ?
Yes, this can be done.
Setting F_SEAL_SHRINK and F_SEAL_GROW after the ftruncate() call above could catch
some potential errors related to improper access to the shared memory allocated by
the SharedMemObject.
---
2. Reconsider stats sharing 2. Reconsider stats sharing
>>> +void SwStatsCpu::finishFrame(void) >>> +void SwStatsCpu::finishFrame(void)