NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

v4l2: camera_proxy: Pass const reference to setFmtFromConfig()

Browse source 
The setFmtFromConfig() method doesn't modify its parameter, make it
const.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
This commit is contained in:
Laurent Pinchart 2020-01-05 01:38:56 +02:00
parent da3c15c3de
commit a6c831a996
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/v4l2/v4l2_camera_proxy.cpp
View file

@ -162,10 +162,10 @@ bool V4L2CameraProxy::validateMemoryType(uint32_t memory)
return memory == V4L2_MEMORY_MMAP;
}
void V4L2CameraProxy::setFmtFromConfig(StreamConfiguration &streamConfig)
void V4L2CameraProxy::setFmtFromConfig(const StreamConfiguration &streamConfig)
{
const PixelFormatInfo &info = PixelFormatInfo::info(streamConfig.pixelFormat);
Size size = streamConfig.size;
const Size &size = streamConfig.size;
curV4L2Format_.fmt.pix.width = size.width;
curV4L2Format_.fmt.pix.height = size.height;

2
src/v4l2/v4l2_camera_proxy.h
View file

@ -39,7 +39,7 @@ public:
private:
bool validateBufferType(uint32_t type);
bool validateMemoryType(uint32_t memory);
void setFmtFromConfig(StreamConfiguration &streamConfig);
void setFmtFromConfig(const StreamConfiguration &streamConfig);
void querycap(std::shared_ptr<Camera> camera);
int tryFormat(struct v4l2_format *arg);
enum v4l2_priority maxPriority();