NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

pipeline: raspberrypi: Remove enum BuffferMask from the mojom interface

Browse source 
The BufferMask enum provides a way of identifying which stream a frame buffer
belongs to. This enum is defined in the raspberrypi.mojom interface file.
However, the IPA does not need these enum definitions to mmap buffers that it
uses.

Move this enum out of the raspberrypi.mojom interface file and put it into
the RPi namespace visible only to the pipeline handler. This removes the
need to include the auto-generated IPA interface header in the RPi::Stream
definition.

Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: David Plowman <david.plowman@raspberrypi.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
This commit is contained in:
Naushir Patuck 2022-11-22 15:42:35 +00:00 • committed by Laurent Pinchart
parent 1bcb7539df
commit a857a150e1
5 changed files with 25 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/ipa/raspberrypi/raspberrypi.cpp
View file

@ -515,7 +515,7 @@ void IPARPi::signalStatReady(uint32_t bufferId)
reportMetadata();
statsMetadataComplete.emit(bufferId & MaskID, libcameraMetadata_);
statsMetadataComplete.emit(bufferId, libcameraMetadata_);
}
void IPARPi::signalQueueRequest(const ControlList &controls)
@ -534,7 +534,7 @@ void IPARPi::signalIspPrepare(const ISPConfig &data)
frameCount_++;
/* Ready to push the input buffer into the ISP. */
runIsp.emit(data.bayerBufferId & MaskID);
runIsp.emit(data.bayerBufferId);
}
void IPARPi::reportMetadata()
@ -1001,7 +1001,7 @@ void IPARPi::queueRequest(const ControlList &controls)
void IPARPi::returnEmbeddedBuffer(unsigned int bufferId)
{
embeddedComplete.emit(bufferId & MaskID);
embeddedComplete.emit(bufferId);
}
void IPARPi::prepareISP(const ISPConfig &data)