NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

ipa: rkisp1: agc: Rename frame context update variable to updateMetering

Browse source 
The frame context agc.update variable is used to indicate if the ISP
histogram metering parameters need to be updated. Rename it to
updateMetering to make usage more explicit.

Suggested-by: Paul Elder <paul.elder@ideasonboard.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
This commit is contained in:
Laurent Pinchart 2024-06-17 15:13:09 +03:00
parent 437e601653
commit a8de1f398d
3 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/ipa/rkisp1/algorithms/agc.cpp
View file

@ -250,7 +250,7 @@ void Agc::queueRequest(IPAContext &context,
const auto &meteringMode = controls.get(controls::AeMeteringMode); const auto &meteringMode = controls.get(controls::AeMeteringMode);
if (meteringMode) { if (meteringMode) {
frameContext.agc.update = agc.meteringMode != *meteringMode; frameContext.agc.updateMetering = agc.meteringMode != *meteringMode;
agc.meteringMode = agc.meteringMode =
static_cast<controls::AeMeteringModeEnum>(*meteringMode); static_cast<controls::AeMeteringModeEnum>(*meteringMode);
} }
@ -288,7 +288,7 @@ void Agc::prepare(IPAContext &context, const uint32_t frame,
frameContext.agc.gain = context.activeState.agc.automatic.gain; frameContext.agc.gain = context.activeState.agc.automatic.gain;
} }
if (frame > 0 && !frameContext.agc.update) if (frame > 0 && !frameContext.agc.updateMetering)
return; return;
/* Configure the measurement window. */ /* Configure the measurement window. */

4
src/ipa/rkisp1/ipa_context.cpp
View file

@ -317,8 +317,8 @@ namespace libcamera::ipa::rkisp1 {
* \var IPAFrameContext::agc.maxFrameDuration * \var IPAFrameContext::agc.maxFrameDuration
* \brief Maximum frame duration as set by the FrameDurationLimits control * \brief Maximum frame duration as set by the FrameDurationLimits control
* *
* \var IPAFrameContext::agc.update * \var IPAFrameContext::agc.updateMetering
* \brief Indicate if new ISP parameters need to be applied * \brief Indicate if new ISP AGC metering parameters need to be applied
*/ */
/** /**

2
src/ipa/rkisp1/ipa_context.h
View file

@ -123,7 +123,7 @@ struct IPAFrameContext : public FrameContext {
controls::AeExposureModeEnum exposureMode; controls::AeExposureModeEnum exposureMode;
controls::AeMeteringModeEnum meteringMode; controls::AeMeteringModeEnum meteringMode;
utils::Duration maxFrameDuration; utils::Duration maxFrameDuration;
bool update; bool updateMetering;
} agc; } agc;
struct { struct {