NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

ipa: rpi: controller: rpi: Fix colour gain typo in AGC

Browse source 
A simple typo crept in where the red gain had been re-typed rather
than using the correct green gain. In particular, this was causing
very dark images for sensors that use large red gains, such as the
IMX477 outdoors.

Fixes: 29892f1c56 ("ipa: libipa: colour: Use the RGB class to model RGB values")
Signed-off-by: David Plowman <david.plowman@raspberrypi.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Naushir Patuck <naush@raspberrypi.com>
Tested-by: Naushir Patuck <naush@raspberrypi.com>
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
This commit is contained in:
David Plowman 2025-05-22 14:03:18 +01:00 • committed by Laurent Pinchart
parent 516f365670
commit ad5326c926
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/ipa/rpi/controller/rpi/agc_channel.cpp
View file

@ -717,7 +717,7 @@ static double computeInitialY(StatisticsPtr &stats, AwbStatus const &awb,
/* Factor in the AWB correction if needed. */ /* Factor in the AWB correction if needed. */
if (stats->agcStatsPos == Statistics::AgcStatsPos::PreWb) if (stats->agcStatsPos == Statistics::AgcStatsPos::PreWb)
sum *= RGB<double>{ { awb.gainR, awb.gainR, awb.gainB } }; sum *= RGB<double>{ { awb.gainR, awb.gainG, awb.gainB } };
double ySum = ipa::rec601LuminanceFromRGB(sum); double ySum = ipa::rec601LuminanceFromRGB(sum);