NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

libcamera: pipeline: Move camera data classes to the top level scope

Browse source 
Move the pipeline handler camera data classes, defined in the scope of
the respective pipeline handler class, to the top level of the libcamera
namespace. This prepares for the introduction of other classes that will
make use of them in the IPU3 and RkISP1 pipeline handlers. The UVC and
VIMC pipeline handlers are updated as well for consistency.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
This commit is contained in:
Laurent Pinchart 2019-05-17 23:36:00 +03:00
parent 75de3bff9e
commit adc61fc3ce
4 changed files with 79 additions and 79 deletions
Download patch file Download diff file Expand all files Collapse all files

44
src/libcamera/pipeline/ipu3/ipu3.cpp
View file

@ -145,6 +145,25 @@ public:
ImgUDevice::ImgUOutput *device_;
};
class IPU3CameraData : public CameraData
{
public:
IPU3CameraData(PipelineHandler *pipe)
: CameraData(pipe)
{
}
void imguOutputBufferReady(Buffer *buffer);
void imguInputBufferReady(Buffer *buffer);
void cio2BufferReady(Buffer *buffer);
CIO2Device cio2_;
ImgUDevice *imgu_;
IPU3Stream outStream_;
IPU3Stream vfStream_;
};
class PipelineHandlerIPU3 : public PipelineHandler
{
public:
@ -167,25 +186,6 @@ public:
bool match(DeviceEnumerator *enumerator) override;
private:
class IPU3CameraData : public CameraData
{
public:
IPU3CameraData(PipelineHandler *pipe)
: CameraData(pipe)
{
}
void imguOutputBufferReady(Buffer *buffer);
void imguInputBufferReady(Buffer *buffer);
void cio2BufferReady(Buffer *buffer);
CIO2Device cio2_;
ImgUDevice *imgu_;
IPU3Stream outStream_;
IPU3Stream vfStream_;
};
static constexpr unsigned int IPU3_BUFFER_COUNT = 4;
IPU3CameraData *cameraData(const Camera *camera)
@ -749,7 +749,7 @@ int PipelineHandlerIPU3::registerCameras()
* Buffers completed from the ImgU input are immediately queued back to the
* CIO2 unit to continue frame capture.
*/
void PipelineHandlerIPU3::IPU3CameraData::imguInputBufferReady(Buffer *buffer)
void IPU3CameraData::imguInputBufferReady(Buffer *buffer)
{
cio2_.output_->queueBuffer(buffer);
}
@ -760,7 +760,7 @@ void PipelineHandlerIPU3::IPU3CameraData::imguInputBufferReady(Buffer *buffer)
*
* Buffers completed from the ImgU output are directed to the application.
*/
void PipelineHandlerIPU3::IPU3CameraData::imguOutputBufferReady(Buffer *buffer)
void IPU3CameraData::imguOutputBufferReady(Buffer *buffer)
{
Request *request = buffer->request();
@ -785,7 +785,7 @@ void PipelineHandlerIPU3::IPU3CameraData::imguOutputBufferReady(Buffer *buffer)
* Buffers completed from the CIO2 are immediately queued to the ImgU unit
* for further processing.
*/
void PipelineHandlerIPU3::IPU3CameraData::cio2BufferReady(Buffer *buffer)
void IPU3CameraData::cio2BufferReady(Buffer *buffer)
{
imgu_->input_->queueBuffer(buffer);
}

34
src/libcamera/pipeline/rkisp1/rkisp1.cpp
View file

@ -28,6 +28,23 @@ namespace libcamera {
LOG_DEFINE_CATEGORY(RkISP1)
class RkISP1CameraData : public CameraData
{
public:
RkISP1CameraData(PipelineHandler *pipe)
: CameraData(pipe), sensor_(nullptr)
{
}
~RkISP1CameraData()
{
delete sensor_;
}
Stream stream_;
CameraSensor *sensor_;
};
class PipelineHandlerRkISP1 : public PipelineHandler
{
public:
@ -51,23 +68,6 @@ public:
bool match(DeviceEnumerator *enumerator) override;
private:
class RkISP1CameraData : public CameraData
{
public:
RkISP1CameraData(PipelineHandler *pipe)
: CameraData(pipe), sensor_(nullptr)
{
}
~RkISP1CameraData()
{
delete sensor_;
}
Stream stream_;
CameraSensor *sensor_;
};
static constexpr unsigned int RKISP1_BUFFER_COUNT = 4;
RkISP1CameraData *cameraData(const Camera *camera)

40
src/libcamera/pipeline/uvcvideo.cpp
View file

@ -20,6 +20,25 @@ namespace libcamera {
LOG_DEFINE_CATEGORY(UVC)
class UVCCameraData : public CameraData
{
public:
UVCCameraData(PipelineHandler *pipe)
: CameraData(pipe), video_(nullptr)
{
}
~UVCCameraData()
{
delete video_;
}
void bufferReady(Buffer *buffer);
V4L2Device *video_;
Stream stream_;
};
class PipelineHandlerUVC : public PipelineHandler
{
public:
@ -42,25 +61,6 @@ public:
bool match(DeviceEnumerator *enumerator) override;
private:
class UVCCameraData : public CameraData
{
public:
UVCCameraData(PipelineHandler *pipe)
: CameraData(pipe), video_(nullptr)
{
}
~UVCCameraData()
{
delete video_;
}
void bufferReady(Buffer *buffer);
V4L2Device *video_;
Stream stream_;
};
UVCCameraData *cameraData(const Camera *camera)
{
return static_cast<UVCCameraData *>(
@ -206,7 +206,7 @@ bool PipelineHandlerUVC::match(DeviceEnumerator *enumerator)
return true;
}
void PipelineHandlerUVC::UVCCameraData::bufferReady(Buffer *buffer)
void UVCCameraData::bufferReady(Buffer *buffer)
{
Request *request = queuedRequests_.front();

40
src/libcamera/pipeline/vimc.cpp
View file

@ -20,6 +20,25 @@ namespace libcamera {
LOG_DEFINE_CATEGORY(VIMC)
class VimcCameraData : public CameraData
{
public:
VimcCameraData(PipelineHandler *pipe)
: CameraData(pipe)
{
}
~VimcCameraData()
{
delete video_;
}
void bufferReady(Buffer *buffer);
V4L2Device *video_;
Stream stream_;
};
class PipelineHandlerVimc : public PipelineHandler
{
public:
@ -42,25 +61,6 @@ public:
bool match(DeviceEnumerator *enumerator) override;
private:
class VimcCameraData : public CameraData
{
public:
VimcCameraData(PipelineHandler *pipe)
: CameraData(pipe)
{
}
~VimcCameraData()
{
delete video_;
}
void bufferReady(Buffer *buffer);
V4L2Device *video_;
Stream stream_;
};
VimcCameraData *cameraData(const Camera *camera)
{
return static_cast<VimcCameraData *>(
@ -202,7 +202,7 @@ bool PipelineHandlerVimc::match(DeviceEnumerator *enumerator)
return true;
}
void PipelineHandlerVimc::VimcCameraData::bufferReady(Buffer *buffer)
void VimcCameraData::bufferReady(Buffer *buffer)
{
Request *request = queuedRequests_.front();