NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

ipa: rpi: Fix the reporting of Focus FoMs

Browse source 
The FocusFom metadata was no longer being reported back because the
"focus.status" metadata was never being created.

Additionally, the scaling of the focus FoMs was over-zealous, rounding
just about everything down to zero.

Fixes: ac7511dc4c ("ipa: raspberrypi: Generalise the focus reporting code")
Signed-off-by: David Plowman <david.plowman@raspberrypi.com>
Reviewed-by: Naushir Patuck <naush@raspberrypi.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
This commit is contained in:
David Plowman 2023-07-20 13:48:23 +01:00 • committed by Laurent Pinchart
parent 09dd65442b
commit baab00721c
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/ipa/rpi/common/ipa_base.cpp
View file

@ -462,6 +462,9 @@ void IpaBase::processStats(const ProcessParams &params)
RPiController::StatisticsPtr statistics = platformProcessStats(it->second.planes()[0]); RPiController::StatisticsPtr statistics = platformProcessStats(it->second.planes()[0]);
/* reportMetadata() will pick this up and set the FocusFoM metadata */
rpiMetadata.set("focus.status", statistics->focusRegions);
helper_->process(statistics, rpiMetadata); helper_->process(statistics, rpiMetadata);
controller_.process(statistics, &rpiMetadata); controller_.process(statistics, &rpiMetadata);
@ -1259,7 +1262,7 @@ void IpaBase::reportMetadata(unsigned int ipaContext)
} }
} }
uint32_t focusFoM = (sum / numRegions) >> 16; uint32_t focusFoM = sum / numRegions;
libcameraMetadata_.set(controls::FocusFoM, focusFoM); libcameraMetadata_.set(controls::FocusFoM, focusFoM);
} }