NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

v4l2: v4l2_camera_proxy: Zero flags in VIDIOC_REQBUFS

Browse source 
The V4L2 compatibility layer doesn't support any of the VIDIOC_REQBUFS
flags. They are all correctly ignored, but also need to be zeroed
before returning to indicate that they haven't been taken into account.

This fixes a v4l2-compliance failure:

Buffer ioctls (Input 0):
                fail: ../../utils/v4l2-compliance/v4l2-test-buffers.cpp(682): coherent
        test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: FAIL

Fixes: aa45336399 ("include: linux: Update kernel headers to version v5.16-rc7")
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Tested-by: Vedant Paranjape <vedantparanjape160201@gmail.com>
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
This commit is contained in:
Laurent Pinchart 2022-01-11 22:23:25 +02:00
parent eff9de397a
commit bc3d27234e
1 changed files with 1 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
src/v4l2/v4l2_camera_proxy.cpp
View file

@ -469,6 +469,7 @@ int V4L2CameraProxy::vidioc_reqbufs(V4L2CameraFile *file, struct v4l2_requestbuf
return -EBUSY; return -EBUSY;
arg->capabilities = V4L2_BUF_CAP_SUPPORTS_MMAP; arg->capabilities = V4L2_BUF_CAP_SUPPORTS_MMAP;
arg->flags = 0;
memset(arg->reserved, 0, sizeof(arg->reserved)); memset(arg->reserved, 0, sizeof(arg->reserved));
if (arg->count == 0) { if (arg->count == 0) {