NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

ipa: camera_sensor_helper: Make factory createInstance() function const

Browse source 
The CameraSensorHelperFactory::createInstance() function has no need to
modify the factory instance. Make it const.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Xavier Roumegue <xavier.roumegue@oss.nxp.com>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
This commit is contained in:
Laurent Pinchart 2022-10-03 22:55:11 +03:00
parent 7465ee8e0c
commit c4d39f0c31
2 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/ipa/libipa/camera_sensor_helper.cpp
View file

@ -254,10 +254,10 @@ CameraSensorHelperFactory::CameraSensorHelperFactory(const std::string name)
*/ */
std::unique_ptr<CameraSensorHelper> CameraSensorHelperFactory::create(const std::string &name) std::unique_ptr<CameraSensorHelper> CameraSensorHelperFactory::create(const std::string &name)
{ {
std::vector<CameraSensorHelperFactory *> &factories = const std::vector<CameraSensorHelperFactory *> &factories =
CameraSensorHelperFactory::factories(); CameraSensorHelperFactory::factories();
for (CameraSensorHelperFactory *factory : factories) { for (const CameraSensorHelperFactory *factory : factories) {
if (name != factory->name_) if (name != factory->name_)
continue; continue;
@ -299,7 +299,7 @@ std::vector<CameraSensorHelperFactory *> &CameraSensorHelperFactory::factories()
} }
/** /**
* \fn CameraSensorHelperFactory::createInstance() * \fn CameraSensorHelperFactory::createInstance() const
* \brief Create an instance of the CameraSensorHelper corresponding to the * \brief Create an instance of the CameraSensorHelper corresponding to the
* factory * factory
* *

4
src/ipa/libipa/camera_sensor_helper.h
View file

@ -70,7 +70,7 @@ public:
static std::vector<CameraSensorHelperFactory *> &factories(); static std::vector<CameraSensorHelperFactory *> &factories();
protected: protected:
virtual CameraSensorHelper *createInstance() = 0; virtual CameraSensorHelper *createInstance() const = 0;
private: private:
LIBCAMERA_DISABLE_COPY_AND_MOVE(CameraSensorHelperFactory) LIBCAMERA_DISABLE_COPY_AND_MOVE(CameraSensorHelperFactory)
@ -85,7 +85,7 @@ public: \
helper##Factory() : CameraSensorHelperFactory(name) {} \ helper##Factory() : CameraSensorHelperFactory(name) {} \
\ \
private: \ private: \
CameraSensorHelper *createInstance() \ CameraSensorHelper *createInstance() const \
{ \ { \
return new helper(); \ return new helper(); \
} \ } \