libcamera: Declare empty virtual destructors as defaulted

The base class of polymorphic classes is required to declare a
destructor. Several of these are empty, and can thus be declared as
defaulted.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Umang Jain <email@uajain.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

include/libcamera/bound_method.h

@@ -26,7 +26,7 @@ enum ConnectionType {
 class BoundMethodPackBase
 {
 public:
-	virtual ~BoundMethodPackBase() {}
+	virtual ~BoundMethodPackBase() = default;
 };
 
 template<typename R, typename... Args>
@@ -61,7 +61,7 @@ public:
 		: obj_(obj), object_(object), connectionType_(type)
 	{
 	}
-	virtual ~BoundMethodBase() {}
+	virtual ~BoundMethodBase() = default;
 
 	template<typename T, typename std::enable_if_t<!std::is_same<Object, T>::value> * = nullptr>
 	bool match(T *obj) { return obj == obj_; }

include/libcamera/internal/control_validator.h

@@ -16,7 +16,7 @@ class ControlId;
 class ControlValidator
 {
 public:
-	virtual ~ControlValidator() {}
+	virtual ~ControlValidator() = default;
 
 	virtual const std::string &name() const = 0;
 	virtual bool validate(unsigned int id) const = 0;

include/libcamera/internal/ipa_proxy.h

@@ -42,7 +42,7 @@ class IPAProxyFactory
 {
 public:
 	IPAProxyFactory(const char *name);
-	virtual ~IPAProxyFactory() {}
+	virtual ~IPAProxyFactory() = default;
 
 	virtual std::unique_ptr<IPAProxy> create(IPAModule *ipam) = 0;
 

include/libcamera/internal/media_object.h

@@ -31,7 +31,7 @@ protected:
 		: dev_(dev), id_(id)
 	{
 	}
-	virtual ~MediaObject() {}
+	virtual ~MediaObject() = default;
 
 	MediaDevice *dev_;
 	unsigned int id_;

include/libcamera/internal/pipeline_handler.h

@@ -40,7 +40,7 @@ public:
 		: pipe_(pipe)
 	{
 	}
-	virtual ~CameraData() {}
+	virtual ~CameraData() = default;
 
 	Camera *camera_;
 	PipelineHandler *pipe_;
@@ -118,7 +118,7 @@ class PipelineHandlerFactory
 {
 public:
 	PipelineHandlerFactory(const char *name);
-	virtual ~PipelineHandlerFactory() {}
+	virtual ~PipelineHandlerFactory() = default;
 
 	std::shared_ptr<PipelineHandler> create(CameraManager *manager);
 

include/libcamera/ipa/ipa_interface.h

@@ -150,7 +150,7 @@ struct CameraSensorInfo;
 class IPAInterface
 {
 public:
-	virtual ~IPAInterface() {}
+	virtual ~IPAInterface() = default;
 
 	virtual int init(const IPASettings &settings) = 0;
 	virtual int start() = 0;

src/android/jpeg/encoder.h

@@ -14,7 +14,7 @@
 class Encoder
 {
 public:
-	virtual ~Encoder() {}
+	virtual ~Encoder() = default;
 
 	virtual int configure(const libcamera::StreamConfiguration &cfg) = 0;
 	virtual int encode(const libcamera::FrameBuffer &source,

src/android/post_processor.h

@@ -16,7 +16,7 @@ class CameraMetadata;
 class PostProcessor
 {
 public:
-	virtual ~PostProcessor() {}
+	virtual ~PostProcessor() = default;
 
 	virtual int configure(const libcamera::StreamConfiguration &inCfg,
 			      const libcamera::StreamConfiguration &outCfg) = 0;

src/cam/options.h

@@ -73,7 +73,7 @@ public:
 	{
 	};
 
-	virtual ~KeyValueParser() {}
+	virtual ~KeyValueParser() = default;
 
 	bool addOption(const char *name, OptionType type, const char *help,
 		       OptionArgument argument = ArgumentNone);

src/ipa/raspberrypi/controller/algorithm.hpp

@@ -30,7 +30,7 @@ public:
 		: controller_(controller), paused_(false)
 	{
 	}
-	virtual ~Algorithm() {}
+	virtual ~Algorithm() = default;
 	virtual char const *Name() const = 0;
 	virtual bool IsPaused() const { return paused_; }
 	virtual void Pause() { paused_ = true; }

src/ipa/raspberrypi/md_parser.hpp

@@ -67,7 +67,7 @@ public:
 		ERROR = 2
 	};
 	MdParser() : reset_(true) {}
-	virtual ~MdParser() {}
+	virtual ~MdParser() = default;
 	void Reset() { reset_ = true; }
 	void SetBitsPerPixel(int bpp) { bits_per_pixel_ = bpp; }
 	void SetNumLines(unsigned int num_lines) { num_lines_ = num_lines; }

src/libcamera/pipeline/rkisp1/timeline.h

@@ -22,7 +22,7 @@ public:
 	FrameAction(unsigned int frame, unsigned int type)
 		: frame_(frame), type_(type) {}
 
-	virtual ~FrameAction() {}
+	virtual ~FrameAction() = default;
 
 	unsigned int frame() const { return frame_; }
 	unsigned int type() const { return type_; }
@@ -38,7 +38,7 @@ class Timeline
 {
 public:
 	Timeline();
-	virtual ~Timeline() {}
+	virtual ~Timeline() = default;
 
 	virtual void reset();
 	virtual void scheduleAction(std::unique_ptr<FrameAction> action);

src/qcam/viewfinder.h

@@ -22,7 +22,7 @@ struct MappedBuffer {
 class ViewFinder
 {
 public:
-	virtual ~ViewFinder() {}
+	virtual ~ViewFinder() = default;
 
 	virtual const QList<libcamera::PixelFormat> &nativeFormats() const = 0;