NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

android: CameraDevice: Deny non ROTATION_0 stream configuration

Browse source 
libcamera doesn't handle crop_rotate_scale_degrees. Therefore,
if it is requested, that is, crop_rotate_scale_degrees is not
CAMERA3_STREAM_ROTATION_0, the configuration should fail.

Signed-off-by: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
This commit is contained in:
Hirokazu Honda 2021-04-03 22:10:15 +09:00 • committed by Laurent Pinchart
parent ac209efabf
commit c85b6c849f
1 changed files with 12 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/android/camera_device.cpp
View file

@ -1703,6 +1703,18 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)
if (!format.isValid()) if (!format.isValid())
return -EINVAL; return -EINVAL;
/* \todo Support rotation. */
if (stream->rotation != CAMERA3_STREAM_ROTATION_0) {
LOG(HAL, Error) << "Rotation is not supported";
return -EINVAL;
}
#if defined(OS_CHROMEOS)
if (stream->crop_rotate_scale_degrees != CAMERA3_STREAM_ROTATION_0) {
LOG(HAL, Error) << "Rotation is not supported";
return -EINVAL;
}
#endif
/* Defer handling of MJPEG streams until all others are known. */ /* Defer handling of MJPEG streams until all others are known. */
if (stream->format == HAL_PIXEL_FORMAT_BLOB) { if (stream->format == HAL_PIXEL_FORMAT_BLOB) {
if (jpegStream) { if (jpegStream) {