NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

test: gstreamer_single_stream_test: Fix memory leak

Browse source 
The test hold a valid reference to convert0_ and sink0_ but
not released. This results in a memory leak and can be checked
via valgrind. Drop the references with test cleanup() virtual
function.

Valgrind log (glib and gst suppression files were used):
==345380== LEAK SUMMARY:
==345380==    definitely lost: 1,688 bytes in 2 blocks
==345380==    indirectly lost: 7,069 bytes in 42 blocks

The patch fixes the leaks reported by valgrind above to:
==348870== LEAK SUMMARY:
==348870==    definitely lost: 0 bytes in 0 blocks
==348870==    indirectly lost: 0 bytes in 0 blocks

Signed-off-by: Vedant Paranjape <vedantparanjape160201@gmail.com>
Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
This commit is contained in:
Vedant Paranjape 2021-09-21 23:09:53 +05:30 • committed by Paul Elder
parent 8d3d92ea81
commit ca9ea1f9ce
1 changed files with 6 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

6
test/gstreamer/gstreamer_single_stream_test.cpp
View file

@ -72,6 +72,12 @@ protected:
return TestPass;
}
void cleanup() override
{
g_clear_object(&convert0_);
g_clear_object(&sink0_);
}
private:
GstElement *convert0_;
GstElement *sink0_;