NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

utils: ipc: ipa_proxy_worker: Log IPCUnixSocket::send() failures

Browse source 
The IPCUnixSocket::send() function may fail, in which case it can be
useful for debugging to log an error message that tells which event was
affected. Do so.

Reported-by: Coverity CID=35483[6-9]
Reported-by: Coverity CID=35484[01]
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
This commit is contained in:
Laurent Pinchart 2021-08-17 06:09:35 +03:00
parent 5b7d16dc1f
commit d0d1733027
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
utils/ipc/generators/libcamera_templates/module_ipa_proxy_worker.cpp.tmpl
View file

@ -164,7 +164,10 @@ private:
{{proxy_funcs.serialize_call(method|method_param_inputs, "_message.data()", "_message.fds()")}}
socket_.send(_message.payload());
int _ret = socket_.send(_message.payload());
if (_ret < 0)
LOG({{proxy_worker_name}}, Error)
<< "Sending event {{method.mojom_name}}() failed: " << _ret;
LOG({{proxy_worker_name}}, Debug) << "{{method.mojom_name}} done";
}