NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

apps: lc-compliance: Optimize std::shared_ptr usage

Browse source 
Avoid unnecessary copies and try to move construct `std::shared_ptr`
whenever possible.

Signed-off-by: Barnabás Pőcze <pobrn@protonmail.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
This commit is contained in:
Barnabás Pőcze 2024-12-20 12:08:55 +01:00
parent 6719ae34cc
commit d338fe9336
2 changed files with 5 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/apps/lc-compliance/helpers/capture.cpp
View file

@ -12,8 +12,8 @@
using namespace libcamera; using namespace libcamera;
Capture::Capture(std::shared_ptr<Camera> camera) Capture::Capture(std::shared_ptr<Camera> camera)
: loop_(nullptr), camera_(camera), : loop_(nullptr), camera_(std::move(camera)),
allocator_(std::make_unique<FrameBufferAllocator>(camera)) allocator_(std::make_unique<FrameBufferAllocator>(camera_))
{ {
} }
@ -72,7 +72,7 @@ void Capture::stop()
/* CaptureBalanced */ /* CaptureBalanced */
CaptureBalanced::CaptureBalanced(std::shared_ptr<Camera> camera) CaptureBalanced::CaptureBalanced(std::shared_ptr<Camera> camera)
: Capture(camera) : Capture(std::move(camera))
{ {
} }
@ -144,7 +144,7 @@ void CaptureBalanced::requestComplete(Request *request)
/* CaptureUnbalanced */ /* CaptureUnbalanced */
CaptureUnbalanced::CaptureUnbalanced(std::shared_ptr<Camera> camera) CaptureUnbalanced::CaptureUnbalanced(std::shared_ptr<Camera> camera)
: Capture(camera) : Capture(std::move(camera))
{ {
} }

4
src/apps/lc-compliance/main.cpp
View file

@ -50,8 +50,6 @@ static void listCameras(CameraManager *cm)
static int initCamera(CameraManager *cm, OptionsParser::Options options) static int initCamera(CameraManager *cm, OptionsParser::Options options)
{ {
std::shared_ptr<Camera> camera;
int ret = cm->start(); int ret = cm->start();
if (ret) { if (ret) {
std::cout << "Failed to start camera manager: " std::cout << "Failed to start camera manager: "
@ -66,7 +64,7 @@ static int initCamera(CameraManager *cm, OptionsParser::Options options)
} }
const std::string &cameraId = options[OptCamera]; const std::string &cameraId = options[OptCamera];
camera = cm->get(cameraId); std::shared_ptr<Camera> camera = cm->get(cameraId);
if (!camera) { if (!camera) {
std::cout << "Camera " << cameraId << " not found, available cameras:" << std::endl; std::cout << "Camera " << cameraId << " not found, available cameras:" << std::endl;
listCameras(cm); listCameras(cm);