NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

ipa: rkisp1: Allow exposure time to be shorter than minimum frame duration limit

Browse source 
The minimum FrameDurationLimit also limits the min exposure time and
results in overly bright AE regulation. Remove the limit on the minimum
exposure time as the vertical blanking ensures the minimum frame
duration limit.

Fixes: f72c76eb6e ("rkisp1: Honor the FrameDurationLimits control")
Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Tested-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
This commit is contained in:
Stefan Klug 2025-02-26 16:59:26 +01:00
parent 74c0e8cbf1
commit d748bdc66d
1 changed files with 1 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/ipa/rkisp1/algorithms/agc.cpp
View file

@ -526,9 +526,7 @@ void Agc::process(IPAContext &context, [[maybe_unused]] const uint32_t frame,
double maxAnalogueGain; double maxAnalogueGain;
if (frameContext.agc.autoExposureEnabled) { if (frameContext.agc.autoExposureEnabled) {
minExposureTime = std::clamp(frameContext.agc.minFrameDuration, minExposureTime = context.configuration.sensor.minExposureTime;
context.configuration.sensor.minExposureTime,
context.configuration.sensor.maxExposureTime);
maxExposureTime = std::clamp(frameContext.agc.maxFrameDuration, maxExposureTime = std::clamp(frameContext.agc.maxFrameDuration,
context.configuration.sensor.minExposureTime, context.configuration.sensor.minExposureTime,
context.configuration.sensor.maxExposureTime); context.configuration.sensor.maxExposureTime);