NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

meson: Remove -Wno-unused-parameter

Browse source 
We build libcamera with -Wno-unused-parameter and this doesn't cause
much issue internally. However, it prevents catching unused parameters
in inline functions defined in public headers. This can lead to
compilation warnings for applications compiled without
-Wno-unused-parameter.

To catch those issues, remove -Wno-unused-parameter and fix all the
related warnings with [[maybe_unused]].

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
This commit is contained in:
Laurent Pinchart 2019-10-27 00:36:13 +03:00
parent 3ef378731a
commit dbafe16da7
40 changed files with 95 additions and 73 deletions
Download patch file Download diff file Expand all files Collapse all files

13
src/ipa/rkisp1/rkisp1.cpp
View file

@ -32,7 +32,10 @@ LOG_DEFINE_CATEGORY(IPARkISP1)
class IPARkISP1 : public IPAInterface
{
public:
int init(const IPASettings &settings) override { return 0; }
int init([[maybe_unused]] const IPASettings &settings) override
{
return 0;
}
int start() override { return 0; }
void stop() override {}
@ -75,11 +78,11 @@ private:
* assemble one. Make sure the reported sensor information are relevant
* before accessing them.
*/
void IPARkISP1::configure(const CameraSensorInfo &info,
const std::map<unsigned int, IPAStream> &streamConfig,
void IPARkISP1::configure([[maybe_unused]] const CameraSensorInfo &info,
[[maybe_unused]] const std::map<unsigned int, IPAStream> &streamConfig,
const std::map<unsigned int, const ControlInfoMap &> &entityControls,
const IPAOperationData &ipaConfig,
IPAOperationData *result)
[[maybe_unused]] const IPAOperationData &ipaConfig,
[[maybe_unused]] IPAOperationData *result)
{
if (entityControls.empty())
return;