NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

utils: ipc: Do not define variables in signal handler up front

Browse source 
Defining the variables at the beginning of the function forces the types
to be default constructible, which may not be desirable; furthermore, it
also forces the move/copy assignment operator to be used when the
deserialized value is retrieved.

Having `T val = f()` has the advantage of benefitting from potential RVO
as well as not requiring `T` to be default constructible, so generate
code in that form by calling `deserialize_call()` with `declare=true`.

Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
This commit is contained in:
Barnabás Pőcze 2025-03-26 09:37:08 +01:00
parent f31da7272e
commit e1818265ae
1 changed files with 1 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

5
utils/codegen/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl
View file

@ -239,10 +239,7 @@ void {{proxy_name}}::{{method.mojom_name}}IPC(
[[maybe_unused]] size_t dataSize, [[maybe_unused]] size_t dataSize,
[[maybe_unused]] const std::vector<SharedFD> &fds) [[maybe_unused]] const std::vector<SharedFD> &fds)
{ {
{%- for param in method.parameters %} {{proxy_funcs.deserialize_call(method.parameters, 'data', 'fds', false, true, true, 'dataSize')}}
{{param|name}} {{param.mojom_name}};
{%- endfor %}
{{proxy_funcs.deserialize_call(method.parameters, 'data', 'fds', false, false, true, 'dataSize')}}
{{method.mojom_name}}.emit({{method.parameters|params_comma_sep}}); {{method.mojom_name}}.emit({{method.parameters|params_comma_sep}});
} }
{% endfor %} {% endfor %}