NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

camera_sensor: Add minimum and maximum line length to IPACameraSensorInfo

Browse source 
Add fields for minimum and maximum line length (in units of pixels) to
the IPACameraSensorInfo structure. This replaces the existing lineLength
field.

Update the ipu3, raspberrypi and rkisp1 IPAs to use
IPACameraSensorInfo::minLineLength instead of
IPACameraSensorInfo::lineLength, as logically we will always want to use
the fastest sensor readout by default.

Since the IPAs now use minLineLength for their calculations, set the
starting value of the V4L2_CID_HBLANK control to its minimum in
CameraSensor::init().

Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
Tested-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
This commit is contained in:
Naushir Patuck 2022-10-10 08:42:32 +01:00 • committed by Laurent Pinchart
parent ae7809307e
commit e5fc0132f8
5 changed files with 51 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

21
include/libcamera/ipa/core.mojom
View file

@ -172,10 +172,17 @@ module libcamera;
*/
/**
* \var IPACameraSensorInfo::lineLength
* \brief Total line length in pixels
* \var IPACameraSensorInfo::minLineLength
* \brief The minimum line length in pixels
*
* The total line length in pixel clock periods, including blanking.
* The minimum allowable line length in pixel clock periods, including blanking.
*/
/**
* \var IPACameraSensorInfo::maxLineLength
* \brief The maximum line length in pixels
*
* The maximum allowable line length in pixel clock periods, including blanking.
*/
/**
@ -189,7 +196,7 @@ module libcamera;
* To obtain the minimum frame duration:
*
* \verbatim
frameDuration(s) = minFrameLength(lines) * lineLength(pixels) / pixelRate(pixels per second)
frameDuration(s) = minFrameLength(lines) * minLineLength(pixels) / pixelRate(pixels per second)
\endverbatim
*/
@ -204,7 +211,7 @@ module libcamera;
* To obtain the maximum frame duration:
*
* \verbatim
frameDuration(s) = maxFrameLength(lines) * lineLength(pixels) / pixelRate(pixels per second)
frameDuration(s) = maxFrameLength(lines) * maxLineLength(pixels) / pixelRate(pixels per second)
\endverbatim
*/
struct IPACameraSensorInfo {
@ -217,7 +224,9 @@ struct IPACameraSensorInfo {
Size outputSize;
uint64 pixelRate;
uint32 lineLength;
uint32 minLineLength;
uint32 maxLineLength;
uint32 minFrameLength;
uint32 maxFrameLength;