NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

utils: codegen: ipc: Simplify return statements

Browse source 
Returning an expression of type `void` from a function returning `void`
is legal, so do not handle those cases specially.

Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
This commit is contained in:
Barnabás Pőcze 2025-05-13 15:00:07 +02:00
parent 4adefc100d
commit e633d85be9
1 changed files with 4 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

10
utils/codegen/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl
View file

@ -127,13 +127,13 @@ void {{proxy_name}}::recvMessage(const IPCMessage &data)
{{proxy_funcs.func_sig(proxy_name, method)}}
{
if (isolate_)
{{"return " if method|method_return_value != "void"}}{{method.mojom_name}}IPC(
return {{method.mojom_name}}IPC(
{%- for param in method|method_param_names -%}
{{param}}{{- ", " if not loop.last}}
{%- endfor -%}
);
else
{{"return " if method|method_return_value != "void"}}{{method.mojom_name}}Thread(
return {{method.mojom_name}}Thread(
{%- for param in method|method_param_names -%}
{{param}}{{- ", " if not loop.last}}
{%- endfor -%}
@ -159,16 +159,14 @@ void {{proxy_name}}::recvMessage(const IPCMessage &data)
state_ = ProxyRunning;
thread_.start();
{{ "return " if method|method_return_value != "void" -}}
proxy_.invokeMethod(&ThreadProxy::start, ConnectionTypeBlocking
return proxy_.invokeMethod(&ThreadProxy::start, ConnectionTypeBlocking
{{- ", " if method|method_param_names}}
{%- for param in method|method_param_names -%}
{{param}}{{- ", " if not loop.last}}
{%- endfor -%}
);
{%- elif not method|is_async %}
{{ "return " if method|method_return_value != "void" -}}
ipa_->{{method.mojom_name}}(
return ipa_->{{method.mojom_name}}(
{%- for param in method|method_param_names -%}
{{param}}{{- ", " if not loop.last}}
{%- endfor -%}