NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

libcamera: v4l2_subdevice: Replace Routing::toString() with operator<<()

Browse source 
The main (and only at the moment) use case for the Routing::toString()
function is to print a representation of the routing table in a log
message. The function is implemented using an std::stringstream, and the
returned std::string is then inserted into an std::ostream. This is
inefficient. Replace the function with a specialization of the
operator<<() and use it in the caller.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
This commit is contained in:
Laurent Pinchart 2024-02-26 16:02:40 +02:00
parent 0d2ad0cd84
commit e8f01b37e8
3 changed files with 18 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

7
include/libcamera/internal/v4l2_subdevice.h
View file

@ -95,11 +95,7 @@ public:
unsigned int stream;
};
class Routing : public std::vector<struct v4l2_subdev_route>
{
public:
std::string toString() const;
};
using Routing = std::vector<struct v4l2_subdev_route>;
explicit V4L2Subdevice(const MediaEntity *entity);
~V4L2Subdevice();
@ -178,5 +174,6 @@ static inline bool operator!=(const V4L2Subdevice::Stream &lhs,
}
std::ostream &operator<<(std::ostream &out, const V4L2Subdevice::Stream &stream);
std::ostream &operator<<(std::ostream &out, const V4L2Subdevice::Routing &routing);
} /* namespace libcamera */