NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

pipeline: rpi: Reset the frame lengths queue during configure

Browse source 
The IPA stores a list of the last 10 frame lengths applied to the
sensor for determining the timeout to use. This list gets reset on
start(), but there is a path through the code that accesses this list
in configure() which happens earlier, causing a logical error.

Fix this by constructing the list with 10 initial values of 0s.

Bug: https://github.com/raspberrypi/libcamera/issues/64
Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: David Plowman <david.plowman@raspberrypi.com>
Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
This commit is contained in:
Naushir Patuck 2023-09-18 10:10:45 +01:00 • committed by Kieran Bingham
parent 51533fecae
commit e991a2887e
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/ipa/rpi/common/ipa_base.cpp
View file

@ -100,8 +100,8 @@ LOG_DEFINE_CATEGORY(IPARPI)
namespace ipa::RPi { namespace ipa::RPi {
IpaBase::IpaBase() IpaBase::IpaBase()
: controller_(), frameCount_(0), mistrustCount_(0), lastRunTimestamp_(0), : controller_(), frameLengths_(FrameLengthsQueueSize, 0s), frameCount_(0),
firstStart_(true), flickerState_({ 0, 0s }) mistrustCount_(0), lastRunTimestamp_(0), firstStart_(true), flickerState_({ 0, 0s })
{ {
} }