NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

libcamera: v4l2: Set colorspace flags

Browse source 
The colorspace fields are read-only from an application point of view,
both on video devices and on subdevs, unless the
V4L2_PIX_FMT_FLAG_SET_CSC or V4L2_MBUS_FRAMEFMT_SET_CSC flags
(respectively) are set when calling the S_FMT ioctl.

Set the flags accordingly within the V4L2SubDevice and V4L2Device when
a colorspace is being set by the application.

Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
This commit is contained in:
Umang Jain 2022-08-12 14:23:24 +05:30
parent 3200bb635c
commit f094c2922a
2 changed files with 19 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/libcamera/v4l2_subdevice.cpp
View file

@ -526,7 +526,13 @@ int V4L2Subdevice::setFormat(unsigned int pad, V4L2SubdeviceFormat *format,
subdevFmt.format.height = format->size.height;
subdevFmt.format.code = format->mbus_code;
subdevFmt.format.field = V4L2_FIELD_NONE;
fromColorSpace(format->colorSpace, subdevFmt.format);
if (format->colorSpace) {
fromColorSpace(format->colorSpace, subdevFmt.format);
/* The CSC flag is only applicable to source pads. */
if (entity_->pads()[pad]->flags() & MEDIA_PAD_FL_SOURCE)
subdevFmt.format.flags |= V4L2_MBUS_FRAMEFMT_SET_CSC;
}
int ret = ioctl(VIDIOC_SUBDEV_S_FMT, &subdevFmt);
if (ret) {

14
src/libcamera/v4l2_videodevice.cpp
View file

@ -953,7 +953,12 @@ int V4L2VideoDevice::trySetFormatMultiplane(V4L2DeviceFormat *format, bool set)
pix->pixelformat = format->fourcc;
pix->num_planes = format->planesCount;
pix->field = V4L2_FIELD_NONE;
fromColorSpace(format->colorSpace, *pix);
if (format->colorSpace) {
fromColorSpace(format->colorSpace, *pix);
if (caps_.isVideoCapture())
pix->flags |= V4L2_PIX_FMT_FLAG_SET_CSC;
}
ASSERT(pix->num_planes <= std::size(pix->plane_fmt));
@ -1023,7 +1028,12 @@ int V4L2VideoDevice::trySetFormatSingleplane(V4L2DeviceFormat *format, bool set)
pix->pixelformat = format->fourcc;
pix->bytesperline = format->planes[0].bpl;
pix->field = V4L2_FIELD_NONE;
fromColorSpace(format->colorSpace, *pix);
if (format->colorSpace) {
fromColorSpace(format->colorSpace, *pix);
if (caps_.isVideoCapture())
pix->flags |= V4L2_PIX_FMT_FLAG_SET_CSC;
}
ret = ioctl(set ? VIDIOC_S_FMT : VIDIOC_TRY_FMT, &v4l2Format);
if (ret) {