NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

libcamera: Mark logPrefix() implementations with override

Browse source 
Virtual functions overriden in derived classes should be marked with the
override keyword. Do so for the logPrefix() implementations inheriting
from the Loggable class.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
This commit is contained in:
Laurent Pinchart 2020-06-04 03:39:30 +03:00
parent b60a7d708a
commit f1cac536f4
4 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
include/libcamera/internal/camera_sensor.h
View file

@ -66,7 +66,7 @@ public:
int sensorInfo(CameraSensorInfo *info) const; int sensorInfo(CameraSensorInfo *info) const;
protected: protected:
std::string logPrefix() const; std::string logPrefix() const override;
private: private:
const MediaEntity *entity_; const MediaEntity *entity_;

2
include/libcamera/internal/media_device.h
View file

@ -55,7 +55,7 @@ public:
Signal<MediaDevice *> disconnected; Signal<MediaDevice *> disconnected;
protected: protected:
std::string logPrefix() const; std::string logPrefix() const override;
private: private:
int open(); int open();

2
include/libcamera/internal/v4l2_subdevice.h
View file

@ -62,7 +62,7 @@ public:
const std::string &entity); const std::string &entity);
protected: protected:
std::string logPrefix() const; std::string logPrefix() const override;
private: private:
std::vector<unsigned int> enumPadCodes(unsigned int pad); std::vector<unsigned int> enumPadCodes(unsigned int pad);

2
include/libcamera/internal/v4l2_videodevice.h
View file

@ -213,7 +213,7 @@ public:
V4L2PixelFormat toV4L2PixelFormat(const PixelFormat &pixelFormat); V4L2PixelFormat toV4L2PixelFormat(const PixelFormat &pixelFormat);
protected: protected:
std::string logPrefix() const; std::string logPrefix() const override;
private: private:
int getFormatMeta(V4L2DeviceFormat *format); int getFormatMeta(V4L2DeviceFormat *format);