NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

libcamera: yaml-parser: Add additional tests

Browse source 
Add additional tests in preparation for upcoming modifications on the
yaml parser. These tests handle the case where the yaml file contains
empty items in dictionaries or lists. E.g.:

dict:
  key_with_value: value
  key_without_value:

Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
This commit is contained in:
Stefan Klug 2024-09-19 14:48:36 +02:00
parent cbfe04f77c
commit f2842258d1
1 changed files with 25 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

28
test/yaml-parser.cpp
View file

@ -34,10 +34,12 @@ static const string testYaml =
"list:\n"
" - James\n"
" - Mary\n"
" - \n"
"dictionary:\n"
" a: 1\n"
" c: 3\n"
" b: 2\n"
" empty:\n"
"level1:\n"
" level2:\n"
" - [1, 2]\n"
@ -430,9 +432,10 @@ protected:
if (testObjectType(listObj, "list", Type::List) != TestPass)
return TestFail;
static constexpr std::array<const char *, 2> listValues{
static constexpr std::array<const char *, 3> listValues{
"James",
"Mary",
"",
};
if (listObj.size() != listValues.size()) {
@ -465,16 +468,23 @@ protected:
i++;
}
/* Ensure that empty objects get parsed as empty strings. */
if (!listObj[2].isValue()) {
cerr << "Empty object is not a value" << std::endl;
return TestFail;
}
/* Test dictionary object */
auto &dictObj = (*root)["dictionary"];
if (testObjectType(dictObj, "dictionary", Type::Dictionary) != TestPass)
return TestFail;
static constexpr std::array<std::pair<const char *, int>, 3> dictValues{ {
static constexpr std::array<std::pair<const char *, int>, 4> dictValues{ {
{ "a", 1 },
{ "c", 3 },
{ "b", 2 },
{ "empty", -100 },
} };
size_t dictSize = dictValues.size();
@ -505,7 +515,7 @@ protected:
return TestFail;
}
if (elem.get<int32_t>(0) != item.second) {
if (elem.get<int32_t>(-100) != item.second) {
std::cerr << "Dictionary element " << i << " has wrong value"
<< std::endl;
return TestFail;
@ -514,6 +524,18 @@ protected:
i++;
}
/* Ensure that empty objects get parsed as empty strings. */
if (!dictObj["empty"].isValue()) {
cerr << "Empty object is not of type value" << std::endl;
return TestFail;
}
/* Ensure that keys without values are added to a dict. */
if (!dictObj.contains("empty")) {
cerr << "Empty element is missing in dict" << std::endl;
return TestFail;
}
/* Make sure utils::map_keys() works on the adapter. */
(void)utils::map_keys(dictObj.asDict());