From f31da7272eb0d8dfcd551057b24b5ca4f6985713 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Barnab=C3=A1s=20P=C5=91cze?= Date: Fri, 21 Mar 2025 10:28:41 +0100 Subject: [PATCH] libcamera: ipa_module: Avoid unnecessary copy when getting signature MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The `signature()` getter can just return a reference to the private vector member variable, and let the caller make a copy if needed. Since the return type is const qualified, this was likely the original intention. Signed-off-by: Barnabás Pőcze Reviewed-by: Laurent Pinchart Reviewed-by: Paul Elder --- include/libcamera/internal/ipa_module.h | 2 +- src/libcamera/ipa_module.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/libcamera/internal/ipa_module.h b/include/libcamera/internal/ipa_module.h index 7c49d3f34..15f19492c 100644 --- a/include/libcamera/internal/ipa_module.h +++ b/include/libcamera/internal/ipa_module.h @@ -29,7 +29,7 @@ public: bool isValid() const; const struct IPAModuleInfo &info() const; - const std::vector signature() const; + const std::vector &signature() const; const std::string &path() const; bool load(); diff --git a/src/libcamera/ipa_module.cpp b/src/libcamera/ipa_module.cpp index 9ca74be6e..e6ea61e44 100644 --- a/src/libcamera/ipa_module.cpp +++ b/src/libcamera/ipa_module.cpp @@ -373,7 +373,7 @@ const struct IPAModuleInfo &IPAModule::info() const * * \return The IPA module signature */ -const std::vector IPAModule::signature() const +const std::vector &IPAModule::signature() const { return signature_; }