NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

libcamera: software_isp: Remove DebayerParams::kGain10

Browse source 
The constant is used in a single place internally and doesn't belong to
DebayerParams anymore.  Let's use 256 directly.

Signed-off-by: Milan Zamazal <mzamazal@redhat.com>
Reviewed-by: Andrei Konovalov <andrey.konovalov.ynk@gmail.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
This commit is contained in:
Milan Zamazal 2024-05-31 14:38:39 +02:00 • committed by Laurent Pinchart
parent 539c62ff8e
commit f5b7921e0a
3 changed files with 1 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

1
include/libcamera/internal/software_isp/debayer_params.h
View file

@ -16,7 +16,6 @@
namespace libcamera { namespace libcamera {
struct DebayerParams { struct DebayerParams {
static constexpr unsigned int kGain10 = 256;
static constexpr unsigned int kRGBLookupSize = 256; static constexpr unsigned int kRGBLookupSize = 256;
using ColorLookupTable = std::array<uint8_t, kRGBLookupSize>; using ColorLookupTable = std::array<uint8_t, kRGBLookupSize>;

3
src/ipa/simple/soft_simple.cpp
View file

@ -289,8 +289,7 @@ void IPASoftSimple::processStats(const ControlList &sensorControls)
for (unsigned int i = 0; i < DebayerParams::kRGBLookupSize; i++) { for (unsigned int i = 0; i < DebayerParams::kRGBLookupSize; i++) {
constexpr unsigned int div = constexpr unsigned int div =
DebayerParams::kRGBLookupSize * DebayerParams::kGain10 / DebayerParams::kRGBLookupSize * 256 / kGammaLookupSize;
kGammaLookupSize;
unsigned int idx; unsigned int idx;
/* Apply gamma after gain! */ /* Apply gamma after gain! */

5
src/libcamera/software_isp/debayer.cpp
View file

@ -18,11 +18,6 @@ namespace libcamera {
* \brief Struct to hold the debayer parameters. * \brief Struct to hold the debayer parameters.
*/ */
/**
* \var DebayerParams::kGain10
* \brief const value for 1.0 gain
*/
/** /**
* \var DebayerParams::kRGBLookupSize * \var DebayerParams::kRGBLookupSize
* \brief Size of a color lookup table * \brief Size of a color lookup table