NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

android: Disallow external location in HAL config

Browse source 
Error out on any camera's location if set to "external", in the HAL
configuration file. The HAL configuration file is meant to override the
location property, and overriding an internal camera location to
external doesn't make sense.

Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
This commit is contained in:
Umang Jain 2021-07-30 16:31:52 +05:30
parent cc0a50cddf
commit f65fad5a4d
1 changed files with 0 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/android/camera_hal_config.cpp
View file

@ -126,8 +126,6 @@ int CameraHalConfig::Private::parseCameraLocation(CameraConfigData *cameraConfig
cameraConfigData->facing = CAMERA_FACING_FRONT;
else if (location == "back")
cameraConfigData->facing = CAMERA_FACING_BACK;
else if (location == "external")
cameraConfigData->facing = CAMERA_FACING_EXTERNAL;
else
return -EINVAL;