NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

gstreamer: Rename variable in gst_libcamera_create_video_pool()

Browse source 
Now that the code is isolated in a function, the video_pool variable in
gst_libcamera_create_video_pool() can be renamed to pool without
clashing with another local variable. Do so to reduce line length.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
This commit is contained in:
Laurent Pinchart 2025-06-04 04:08:20 +03:00
parent 613202b809
commit f7c4fcd301
1 changed files with 8 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

16
src/gstreamer/gstlibcamerasrc.cpp
View file

@ -542,7 +542,7 @@ gst_libcamera_create_video_pool(GstLibcameraSrc *self, GstPad *srcpad,
{ {
GstQuery *query = NULL; GstQuery *query = NULL;
const gboolean need_pool = true; const gboolean need_pool = true;
GstBufferPool *video_pool = NULL; GstBufferPool *pool = NULL;
/* /*
* Get the peer allocation hints to check if it supports the meta API. * Get the peer allocation hints to check if it supports the meta API.
@ -563,22 +563,22 @@ gst_libcamera_create_video_pool(GstLibcameraSrc *self, GstPad *srcpad,
* create a new pool. * create a new pool.
*/ */
if (gst_query_get_n_allocation_pools(query) > 0) if (gst_query_get_n_allocation_pools(query) > 0)
gst_query_parse_nth_allocation_pool(query, 0, &video_pool, NULL, NULL, NULL); gst_query_parse_nth_allocation_pool(query, 0, &pool, NULL, NULL, NULL);
if (!video_pool) { if (!pool) {
GstStructure *config; GstStructure *config;
guint min_buffers = 3; guint min_buffers = 3;
video_pool = gst_video_buffer_pool_new(); pool = gst_video_buffer_pool_new();
config = gst_buffer_pool_get_config(video_pool); config = gst_buffer_pool_get_config(pool);
gst_buffer_pool_config_set_params(config, caps, info->size, min_buffers, 0); gst_buffer_pool_config_set_params(config, caps, info->size, min_buffers, 0);
GST_DEBUG_OBJECT(self, "Own pool config is %" GST_PTR_FORMAT, config); GST_DEBUG_OBJECT(self, "Own pool config is %" GST_PTR_FORMAT, config);
gst_buffer_pool_set_config(GST_BUFFER_POOL_CAST(video_pool), config); gst_buffer_pool_set_config(GST_BUFFER_POOL_CAST(pool), config);
} }
if (!gst_buffer_pool_set_active(video_pool, true)) { if (!gst_buffer_pool_set_active(pool, true)) {
gst_caps_unref(caps); gst_caps_unref(caps);
GST_ELEMENT_ERROR(self, RESOURCE, SETTINGS, GST_ELEMENT_ERROR(self, RESOURCE, SETTINGS,
("Failed to active buffer pool"), ("Failed to active buffer pool"),
@ -587,7 +587,7 @@ gst_libcamera_create_video_pool(GstLibcameraSrc *self, GstPad *srcpad,
} }
gst_query_unref(query); gst_query_unref(query);
return { video_pool, 0 }; return { pool, 0 };
} }
/* Must be called with stream_lock held. */ /* Must be called with stream_lock held. */