From fae2b506d7ce8df6149e1eedf147cb35838fbb16 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Barnab=C3=A1s=20P=C5=91cze?=
 <barnabas.pocze@ideasonboard.com>
Date: Tue, 25 Mar 2025 18:02:59 +0100
Subject: [PATCH] libcamera: process: Return error if already running
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Returning 0 when a running process is already managed can be confusing
since the parameters might be completely different, causing the caller
to mistakenly assume that the program it specified has been started.

Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 src/libcamera/process.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/libcamera/process.cpp b/src/libcamera/process.cpp
index f4e4b004c..edbe8664a 100644
--- a/src/libcamera/process.cpp
+++ b/src/libcamera/process.cpp
@@ -241,7 +241,7 @@ int Process::start(const std::string &path,
 	int ret;
 
 	if (running_)
-		return 0;
+		return -EBUSY;
 
 	int childPid = fork();
 	if (childPid == -1) {