NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

libcamera: media_device: Rename valid() function to isValid()

Browse source 
We use isValid() instead of valid() through the code base, make
MediaDevice consistent.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
This commit is contained in:
Laurent Pinchart 2021-04-13 21:24:37 +03:00
parent fe70472e9b
commit fcccd7991f
2 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
include/libcamera/internal/media_device.h
View file

@ -35,7 +35,7 @@ public:
void unlock(); void unlock();
int populate(); int populate();
bool valid() const { return valid_; } bool isValid() const { return valid_; }
const std::string driver() const { return driver_; } const std::string driver() const { return driver_; }
const std::string deviceNode() const { return deviceNode_; } const std::string deviceNode() const { return deviceNode_; }

6
src/libcamera/media_device.cpp
View file

@ -44,7 +44,7 @@ LOG_DEFINE_CATEGORY(MediaDevice)
* MediaEntity, MediaPad and MediaLink are created to model the media graph, * MediaEntity, MediaPad and MediaLink are created to model the media graph,
* and stored in a map indexed by object id. * and stored in a map indexed by object id.
* *
* The graph is valid once successfully populated, as reported by the valid() * The graph is valid once successfully populated, as reported by the isValid()
* function. It can be queried to list all entities(), or entities can be * function. It can be queried to list all entities(), or entities can be
* looked up by name with getEntityByName(). The graph can be traversed from * looked up by name with getEntityByName(). The graph can be traversed from
* entity to entity through pads and links as exposed by the corresponding * entity to entity through pads and links as exposed by the corresponding
@ -292,7 +292,7 @@ done:
} }
/** /**
* \fn MediaDevice::valid() * \fn MediaDevice::isValid()
* \brief Query whether the media graph has been populated and is valid * \brief Query whether the media graph has been populated and is valid
* \return true if the media graph is valid, false otherwise * \return true if the media graph is valid, false otherwise
*/ */
@ -571,7 +571,7 @@ bool MediaDevice::addObject(MediaObject *object)
* *
* The media device graph state is reset to invalid when the graph is cleared. * The media device graph state is reset to invalid when the graph is cleared.
* *
* \sa valid() * \sa isValid()
*/ */
void MediaDevice::clear() void MediaDevice::clear()
{ {