NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

pipeline: rkisp1: Enable the dewarper unconditionally

Browse source 
In configure() and in the future in generateConfiguration() the
calculated stream sizes and crop rectangles depend on the dewarper being
available or not. It is therefore not possible to disable the dewarper
later if configuration fails. Error out in that case.

Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>
Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
This commit is contained in:
Stefan Klug 2024-12-16 16:40:55 +01:00
parent f0e12b0fc8
commit fd71913d70
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/libcamera/pipeline/rkisp1/rkisp1.cpp
View file

@ -865,7 +865,10 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)
if (dewarper_ && !isRaw_) { if (dewarper_ && !isRaw_) {
outputCfgs.push_back(const_cast<StreamConfiguration &>(cfg)); outputCfgs.push_back(const_cast<StreamConfiguration &>(cfg));
ret = dewarper_->configure(cfg, outputCfgs); ret = dewarper_->configure(cfg, outputCfgs);
useDewarper_ = ret ? false : true; if (ret)
return ret;
useDewarper_ = true;
/* /*
* Calculate the crop rectangle of the data * Calculate the crop rectangle of the data