NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

libcamera: MappedFrameBuffer: Use typed Flags<MapModes>

Browse source 
Remove the need for callers to reference PROT_READ/PROT_WRITE directly
from <sys/mman.h> by instead exposing the Read/Write mapping options as
flags from the MappedFrameBuffer class itself.

While here, introduce the <stdint.h> header which is required for the
uint8_t as part of the Plane.

Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
This commit is contained in:
Kieran Bingham 2021-08-06 13:18:01 +01:00
parent f3629363c4
commit fdf1851f0b
8 changed files with 51 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

15
include/libcamera/internal/mapped_framebuffer.h
View file

@ -7,10 +7,11 @@
#ifndef __LIBCAMERA_INTERNAL_MAPPED_FRAMEBUFFER_H__
#define __LIBCAMERA_INTERNAL_MAPPED_FRAMEBUFFER_H__
#include <sys/mman.h>
#include <stdint.h>
#include <vector>
#include <libcamera/base/class.h>
#include <libcamera/base/flags.h>
#include <libcamera/base/span.h>
#include <libcamera/framebuffer.h>
@ -44,9 +45,19 @@ private:
class MappedFrameBuffer : public MappedBuffer
{
public:
MappedFrameBuffer(const FrameBuffer *buffer, int flags);
enum class MapFlag {
Read = 1 << 0,
Write = 1 << 1,
ReadWrite = Read | Write,
};
using MapFlags = Flags<MapFlag>;
MappedFrameBuffer(const FrameBuffer *buffer, MapFlags flags);
};
LIBCAMERA_FLAGS_ENABLE_OPERATORS(MappedFrameBuffer::MapFlag)
} /* namespace libcamera */
#endif /* __LIBCAMERA_INTERNAL_MAPPED_FRAMEBUFFER_H__ */