NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

pipeline: rpi: Don't call toV4L2DeviceFormat() from validate()

Browse source 
Don't make an unnecessary call to toV4L2DeviceFormat() from validate()
to get a V4L2DeviceFormat. Instead, the conversion can happen directly
from the RAW stream PixelFormat.

Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
This commit is contained in:
Naushir Patuck 2023-07-27 14:01:07 +01:00 • committed by Jacopo Mondi
parent eed6a079d2
commit fe73f05475
1 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/libcamera/pipeline/rpi/common/pipeline_base.cpp
View file

@ -226,10 +226,11 @@ CameraConfiguration::Status RPiCameraConfiguration::validate()
/* Further fixups on the RAW streams. */
for (auto &raw : rawStreams) {
StreamConfiguration &cfg = config_.at(raw.index);
V4L2DeviceFormat rawFormat;
BayerFormat::Packing packing = BayerFormat::fromPixelFormat(cfg.pixelFormat).packing;
rawFormat = PipelineHandlerBase::toV4L2DeviceFormat(raw.dev, sensorFormat_, packing);
V4L2DeviceFormat rawFormat;
rawFormat.fourcc = raw.dev->toV4L2PixelFormat(cfg.pixelFormat);
rawFormat.size = cfg.size;
rawFormat.colorSpace = cfg.colorSpace;
int ret = raw.dev->tryFormat(&rawFormat);
if (ret)