03fcc154eb
exportBuffers() can only operate on an existing BufferPool allocation. The pool identifies its size through its .count() method. Passing a count in to the exportBuffers() call is redundant and can be incorrect if the value is not the same as the BufferPool size. Simplify the function and remove the unnecessary argument, correcting all uses throughout the code base. While we're here, remove the createBuffers() helper from the V4L2DeviceTest which only served to obfuscate which pool the buffers were being allocated for. Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
32 lines
529 B
C++
32 lines
529 B
C++
/* SPDX-License-Identifier: GPL-2.0-or-later */
|
|
/*
|
|
* Copyright (C) 2019, Google Inc.
|
|
*
|
|
* libcamera V4L2 API tests
|
|
*/
|
|
|
|
#include "v4l2_device_test.h"
|
|
|
|
class RequestBuffersTest : public V4L2DeviceTest
|
|
{
|
|
protected:
|
|
int run()
|
|
{
|
|
/*
|
|
* TODO:
|
|
* Test invalid requests
|
|
* Test different buffer allocations
|
|
*/
|
|
const unsigned int bufferCount = 8;
|
|
|
|
pool_.createBuffers(bufferCount);
|
|
|
|
int ret = dev_->exportBuffers(&pool_);
|
|
if (ret)
|
|
return TestFail;
|
|
|
|
return TestPass;
|
|
}
|
|
};
|
|
|
|
TEST_REGISTER(RequestBuffersTest);
|