626172a16b
Source files in libcamera start by a comment block header, which
includes the file name and a one-line description of the file contents.
While the latter is useful to get a quick overview of the file contents
at a glance, the former is mostly a source of inconvenience. The name in
the comments can easily get out of sync with the file name when files
are renamed, and copy & paste during development have often lead to
incorrect names being used to start with.
Readers of the source code are expected to know which file they're
looking it. Drop the file name from the header comment block.
The change was generated with the following script:
----------------------------------------
dirs="include/libcamera src test utils"
declare -rA patterns=(
['c']=' \* '
['cpp']=' \* '
['h']=' \* '
['py']='# '
['sh']='# '
)
for ext in ${!patterns[@]} ; do
files=$(for dir in $dirs ; do find $dir -name "*.${ext}" ; done)
pattern=${patterns[${ext}]}
for file in $files ; do
name=$(basename ${file})
sed -i "s/^\(${pattern}\)${name} - /\1/" "$file"
done
done
----------------------------------------
This misses several files that are out of sync with the comment block
header. Those will be addressed separately and manually.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>
39 lines
1.3 KiB
Python
Executable file
39 lines
1.3 KiB
Python
Executable file
#!/usr/bin/env python3
|
|
# SPDX-License-Identifier: BSD-3-Clause
|
|
# Copyright (C) 2020, Google Inc.
|
|
#
|
|
# Author: Paul Elder <paul.elder@ideasonboard.com>
|
|
#
|
|
# Run mojo code generator for generating libcamera IPC files
|
|
|
|
import os
|
|
import sys
|
|
|
|
# TODO set sys.pycache_prefix for >= python3.8
|
|
sys.dont_write_bytecode = True
|
|
|
|
sys.path.insert(0, f'{os.path.dirname(__file__)}/mojo/public/tools/bindings')
|
|
|
|
import mojo.public.tools.bindings.mojom_bindings_generator as generator
|
|
|
|
def _GetModulePath(path, output_dir):
|
|
return os.path.join(output_dir, path.relative_path())
|
|
|
|
|
|
# Disable the attribute checker to support our custom attributes. Ideally we
|
|
# should add the attributes to the list of allowed attributes in
|
|
# utils/ipc/mojo/public/tools/bindings/checks/mojom_attributes_check.py, but
|
|
# we're trying hard to use the upstream mojom as-is.
|
|
if hasattr(generator, '_BUILTIN_CHECKS'):
|
|
del generator._BUILTIN_CHECKS['attributes']
|
|
|
|
# Override the mojo code generator's generator list to only contain our
|
|
# libcamera generator
|
|
generator._BUILTIN_GENERATORS = {'libcamera': 'mojom_libcamera_generator'}
|
|
|
|
# Override the mojo code generator's _GetModulePath method to not add
|
|
# the '-module' suffix when searching for mojo modules, so that we can
|
|
# pass the path to the mojom module without having to trim the '-module' suffix
|
|
generator._GetModulePath = _GetModulePath
|
|
|
|
generator.main()
|